Ahmed Hashim's Blog

J2SE Archives

Compare String to a literal.. coding style

I saw many times code written by geeks, comparing String to literals in this style

public boolean compareUser(String name)
{
if("Ahmed Hashim".equals(name))
{
//do staff here
return true;
}
return false;
}

public boolean compareUser(String name)
{
if(name.equals("Ahmed Hashim"))
{
//do staff here
return true;
}
return false;
}

compareUser(null);

I think you got it, passing null will not need check in the first version because you are not accessing the “.equals” method inside the passed object, while the 2nd version will cause NullPointerException!

Mirror:
http://egjug.org/hashimblog/2007/03/08/compare-string-to-a-literal-coding-style/

This work is licensed under a Creative Commons License.