Skip to main content

SailFin: Crucible for Code Review

Posted by binod on September 24, 2008 at 7:43 AM PDT

This time, my work had about 800 lines changes/new lines spanning 16 files and was implementing two RFCs. All that was plain simple java code and not very complicated, but still the worry I always had about presenting the changes to the reviewers (in different geos) came up on my head. It is still my code and not their code. It should be as easy as possible for them to understand the changes and review them.

Fortunately atlassian folks helped me here. They setup Crucible 1.6 beta for SailFin and gave us a page for signing up. It solved most of my worries on sending these changes for review.

  1. Crucible gives a web page where you can upload your patches. (cvs -upN diff).
  2. Crucible converts your patch to distinct files, color coding for the diffs etc
  3. Comments can be added right into the code itself

Here is a copy of my changeset in crucible demo project, currently under review.

Crucible has been around for a while... And if you havent yet checked out, please do.

Related Topics >>