A Mojarra code review story
Last week, I sent a code review request to the Mojarra dev list. As you can see, no-one responded, but when a good friend and longtime Mojarra comitter (the winner of this contest) popped into the JSF IRC chat room, I asked him to review the changebundle.
We played IM tag for a while and when he finally caught me he brought a potential issue to my attention. The issue hinges on the answer to this quention: What happens when YOURAPP is deployed at http://www.server.com/a/b/c/YOURAPP and you call
externalContext.getRequestContextPath()? Does it return "/YOURAPP" or "/a/b/c/YOURAPP"? My friend even found this very apropos forum question: <http://java.itags.org/java-web-tier-apis/18160/>. Thanks to some still-yet-to-be-blogged-about efforts with Hudson, I was able to get the line in question in the source level debugger in less than two minutes, with the absolute latest checked out source. It turns out, in GlassFish 3.1 at least, it returns "/a/b/c/YOURAPP", which is correct.
This blog post illustrates a win for community and agility, benefitting the Mojarra project.