Skip to main content

A Mojarra code review story

Posted by edburns on December 9, 2010 at 7:31 AM PST

Last week, I sent a code review request to the Mojarra dev list. As you can see, no-one responded, but when a good friend and longtime Mojarra comitter (the winner of this contest) popped into the JSF IRC chat room, I asked him to review the changebundle.

We played IM tag for a while and when he finally caught me he brought a potential issue to my attention. The issue hinges on the answer to this quention: What happens when YOURAPP is deployed at http://www.server.com/a/b/c/YOURAPP and you call externalContext.getRequestContextPath()? Does it return "/YOURAPP" or "/a/b/c/YOURAPP"? My friend even found this very apropos forum question: <http://java.itags.org/java-web-tier-apis/18160/>. Thanks to some still-yet-to-be-blogged-about efforts with Hudson, I was able to get the line in question in the source level debugger in less than two minutes, with the absolute latest checked out source. It turns out, in GlassFish 3.1 at least, it returns "/a/b/c/YOURAPP", which is correct.

This blog post illustrates a win for community and agility, benefitting the Mojarra project.

Technorati Tags:

Related Topics >>

Comments

A Mojarra code review story

Hello All,
I am fanat of JSF and develop with JSF personal and corporite sites.
My personal site in JSF 1.2 is lastpubs.com.
But I have one question-
Is JSF 2.0 solve problem with memory? JSF 1.2 eat a lot of memory in the server side and for
a lot of users it can be unconfortable.
We solve that problem with clusters, but if I want make site like forums or chats or facebook, I think JSF will catch a lot of memory.
I do not use a lot of sessions beans, it is a wrong way for programming.
I interested full answer for JSF 2.0 Performance and memory management.
Best Regards,